fix: include error context in top level of errors

lib/ash/error/error.ex

@@ -575,10 +575,17 @@ defmodule Ash.Error do
   defp header(:framework), do: "Framework Error"
   defp header(:unknown), do: "Unknown Error"
 
-  defp breadcrumb(nil), do: ""
+  @doc false
-  defp breadcrumb([]), do: ""
+  def breadcrumb(nil), do: ""
+  def breadcrumb([]), do: ""
 
-  defp breadcrumb(error_context) do
+  def breadcrumb(error_context) do
-    "Context: " <> Enum.join(error_context, " > ") <> "\n"
+    case Enum.filter(error_context, & &1) do
+      [] ->
+        ""
+
+      bread_crumbs ->
+        "Context: " <> Enum.join(bread_crumbs, " > ") <> "\n"
+    end
   end
 end

lib/ash/error/forbidden.ex

@@ -8,12 +8,16 @@ defmodule Ash.Error.Forbidden do
   defimpl Ash.ErrorKind do
     def id(_), do: Ash.UUID.generate()
 
-    def message(%{errors: errors, stacktraces?: stacktraces?}) when not is_nil(errors) do
+    def message(%{errors: errors, stacktraces?: stacktraces?, error_context: error_context}) do
-      Ash.Error.error_messages(errors, nil, stacktraces?)
+      messages = Ash.Error.error_messages(errors, nil, stacktraces?)
-    end
 
-    def message(%{errors: errors}) do
+      case Ash.Error.breadcrumb(error_context) do
-      Ash.Error.error_descriptions(errors)
+        "" ->
+          messages
+
+        error_context ->
+          error_context <> "\n" <> messages
+      end
     end
 
     def code(_), do: "Forbidden"

lib/ash/error/framework.ex

@@ -9,8 +9,16 @@ defmodule Ash.Error.Framework do
 
     def code(_), do: "framework"
 
-    def message(%{errors: errors, stacktraces?: stacktraces?}) do
+    def message(%{errors: errors, stacktraces?: stacktraces?, error_context: error_context}) do
-      Ash.Error.error_messages(errors, nil, stacktraces?)
+      messages = Ash.Error.error_messages(errors, nil, stacktraces?)
+
+      case Ash.Error.breadcrumb(error_context) do
+        "" ->
+          messages
+
+        error_context ->
+          error_context <> "\n" <> messages
+      end
     end
   end
 end

lib/ash/error/invalid.ex

@@ -9,8 +9,16 @@ defmodule Ash.Error.Invalid do
 
     def code(_), do: "invalid"
 
-    def message(%{errors: errors, stacktraces?: stacktraces?}) do
+    def message(%{errors: errors, stacktraces?: stacktraces?, error_context: error_context}) do
-      Ash.Error.error_messages(errors, nil, stacktraces?)
+      messages = Ash.Error.error_messages(errors, nil, stacktraces?)
+
+      case Ash.Error.breadcrumb(error_context) do
+        "" ->
+          messages
+
+        error_context ->
+          error_context <> "\n" <> messages
+      end
     end
   end
 end

lib/ash/error/unknown.ex

@@ -17,8 +17,16 @@ defmodule Ash.Error.Unknown do
 
     def code(_), do: "unknown"
 
-    def message(%{errors: errors, stacktraces?: stacktraces?}) do
+    def message(%{errors: errors, stacktraces?: stacktraces?, error_context: error_context}) do
-      Ash.Error.error_messages(errors, nil, stacktraces?)
+      messages = Ash.Error.error_messages(errors, nil, stacktraces?)
+
+      case Ash.Error.breadcrumb(error_context) do
+        "" ->
+          messages
+
+        error_context ->
+          error_context <> "\n" <> messages
+      end
     end
   end
 end