ash-project/ash
1
0
Fork 0
mirror of https://github.com/ash-project/ash.git synced 2024-09-20 05:23:03 +12:00
Code Issues Projects Releases Packages Wiki Activity

fix: properly surface errors from embedded attributes

Browse source
This commit is contained in:
Zach Daniel 2023-01-22 10:40:38 -05:00
parent 0a76ee77da
commit 71dcb17e8b
1 changed files with 52 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

74
lib/ash/changeset/changeset.ex
View file

@ -3337,32 +3337,57 @@ defmodule Ash.Changeset do
end
Enum.reduce(messages, changeset, fn message, changeset ->
opts = error_to_exception_opts(message, attribute)
exception =
case type do
:attribute -> InvalidAttribute
:argument -> InvalidArgument
end
Enum.reduce(opts, changeset, fn opts, changeset ->
if Exception.exception?(message) do
error =
exception.exception(
value: value,
field: Keyword.get(opts, :field),
message: Keyword.get(opts, :message),
vars: opts
)
message
|> Ash.Error.to_ash_error()
error =
if opts[:path] do
Ash.Error.set_path(error, opts[:path])
else
error
errors =
case error do
%class{errors: errors}
when class in [
Ash.Error.Invalid,
Ash.Error.Unknown,
Ash.Error.Forbidden,
Ash.Error.Framework
] ->
errors
error ->
[error]
end
add_error(changeset, error)
end)
Enum.reduce(errors, changeset, fn error, changeset ->
add_error(changeset, Ash.Error.set_path(error, attribute.name))
end)
else
opts = error_to_exception_opts(message, attribute)
exception =
case type do
:attribute -> InvalidAttribute
:argument -> InvalidArgument
end
Enum.reduce(opts, changeset, fn opts, changeset ->
error =
exception.exception(
value: value,
field: Keyword.get(opts, :field),
message: Keyword.get(opts, :message),
vars: opts
)
error =
if opts[:path] do
Ash.Error.set_path(error, opts[:path])
else
error
end
add_error(changeset, error)
end)
end
end)
end
@ -3404,6 +3429,11 @@ defmodule Ash.Changeset do
message when is_binary(message) ->
[[field: attribute.name, message: message]]
value when is_exception(value) ->
value
|> Ash.Error.to_ash_error()
|> Map.put(:field, attribute.name)
_ ->
[[field: attribute.name]]
end