improvement: add actor_present policy

lib/ash/policy/check/actor_present.ex

@@ -0,0 +1,13 @@
+defmodule Ash.Policy.Check.ActorPresent do
+  @moduledoc false
+  use Ash.Policy.SimpleCheck
+
+  @impl true
+  def describe(_) do
+    "actor is present"
+  end
+
+  @impl true
+  def match?(nil, _, _opts), do: false
+  def match?(_, _, _opts), do: true
+end

lib/ash/policy/check/built_in_checks.ex

@@ -21,6 +21,11 @@ defmodule Ash.Policy.Check.BuiltInChecks do
     {Ash.Policy.Check.Action, action: action}
   end
 
+  @doc "This check is true when there is an actor specified, and false when the actor is `nil`"
+  def actor_present do
+    Ash.Policy.Check.ActorPresent
+  end
+
   @doc "This check is true when the field is being selected and false when it is not"
   def selecting(attribute) do
     {Ash.Policy.Check.Selecting, attribute: attribute}

lib/ash/query/function/contains.ex

@@ -19,10 +19,10 @@ defmodule Ash.Query.Function.Contains do
 
   def args,
     do: [
-      [:string, :string],
       [:ci_string, :ci_string],
       [:string, :ci_string],
-      [:ci_string, :string]
+      [:ci_string, :string],
+      [:string, :string]
     ]
 
   def evaluate(%{arguments: [nil, _]}), do: {:known, false}