ash/test/policy/simple_test.exs
Zach Daniel 5f5cccc2ea improvement: show informative error explaining the use of filter checks with create actions
improvement: show the actor's primary key in policy breakdowns
improvement: add an expanded description option to checks
improvement: use expanded description to display filled in filter templates in policy breakdowns
2024-09-06 09:46:27 -04:00

575 lines
16 KiB
Elixir

defmodule Ash.Test.Policy.SimpleTest do
@doc false
use ExUnit.Case
require Ash.Query
alias Ash.Test.Support.PolicySimple.{
Car,
Context,
Domain,
Foo,
Organization,
Post,
Trip,
Tweet,
User
}
defmodule ResourceWithNoPolicies do
use Ash.Resource,
domain: Ash.Test.Domain,
authorizers: [Ash.Policy.Authorizer]
attributes do
uuid_primary_key :id
end
actions do
defaults [:create, :read]
end
end
defmodule ResourceWithAPolicyThatDoesntApply do
use Ash.Resource,
domain: Ash.Test.Domain,
authorizers: [Ash.Policy.Authorizer]
attributes do
uuid_primary_key :id
end
actions do
defaults [:create, :read]
end
policies do
policy never() do
authorize_if always()
end
end
end
defmodule ResourceWithAStrictReadPolicy do
use Ash.Resource,
domain: Ash.Test.Domain,
authorizers: [Ash.Policy.Authorizer]
attributes do
uuid_primary_key :id
end
actions do
defaults [:create, :read]
end
policies do
policy action_type(:read) do
access_type :strict
authorize_if actor_attribute_equals(:admin, true)
end
policy action_type(:read) do
authorize_if expr(id == ^actor(:id))
end
end
end
defmodule ResourceWithAnImpossibleCreatePolicy do
use Ash.Resource,
domain: Ash.Test.Domain,
data_layer: Ash.DataLayer.Ets,
authorizers: [Ash.Policy.Authorizer]
ets do
private? true
end
attributes do
uuid_primary_key :id
end
actions do
defaults [:create, :read]
end
policies do
policy action(:create) do
authorize_if expr(self.id == ^actor(:id))
end
end
relationships do
belongs_to :self, ResourceWithAnImpossibleCreatePolicy do
filterable? true
source_attribute :id
destination_attribute :id
end
end
end
defmodule OldEnoughToDrink do
use Ash.Policy.FilterCheck
@impl true
def describe(_opts) do
"is old enough to drink"
end
@impl true
def filter(_, _, _opts) do
expr(age > 21)
end
end
defmodule ResourceWithFailedFilterTest do
use Ash.Resource,
domain: Ash.Test.Domain,
data_layer: Ash.DataLayer.Ets,
authorizers: [Ash.Policy.Authorizer]
ets do
private? true
end
attributes do
uuid_primary_key :id
attribute :age, :integer
end
actions do
defaults [:create, :read, :update]
end
policies do
policy action(:create) do
authorize_if always()
end
policy action(:update) do
authorize_if OldEnoughToDrink
authorize_if expr(id == ^actor(:id))
end
end
end
setup do
old_env = Application.get_env(:ash, :policies, [])
Application.put_env(
:ash,
:policies,
Keyword.merge(old_env, show_policy_breakdowns?: true)
)
on_exit(fn ->
Application.put_env(:ash, :policies, old_env)
end)
[
user: Ash.create!(Ash.Changeset.for_create(User, :create), authorize?: false),
admin:
Ash.create!(Ash.Changeset.for_create(User, :create, %{admin: true}), authorize?: false)
]
end
test "breakdowns for resources with no policies explain the error" do
assert_raise Ash.Error.Forbidden,
~r/No policies defined on `Ash.Test.Domain` or `Ash.Test.Policy.SimpleTest.ResourceWithNoPolicies`/,
fn ->
ResourceWithNoPolicies
|> Ash.read!()
end
end
test "breakdowns for action where no policies that apply explain the error" do
assert_raise Ash.Error.Forbidden,
~r/No policy conditions applied to this request/,
fn ->
ResourceWithAPolicyThatDoesntApply
|> Ash.read!()
end
end
test "an impossible create policy shows the correct error message" do
assert_raise Ash.Error.Forbidden, ~r/Cannot use a filter to authorize a create/, fn ->
ResourceWithAnImpossibleCreatePolicy
|> Ash.create!(%{}, actor: %{id: 10})
end
end
test "a filter check shows a more in-depth breakdown of filter checks" do
actor_id = Ash.UUID.generate()
exception =
assert_raise Ash.Error.Forbidden, fn ->
ResourceWithFailedFilterTest
|> Ash.create!(%{}, actor: %{id: actor_id})
|> Ash.Changeset.for_update(:update, %{})
|> Ash.update!(%{}, actor: %{id: actor_id})
end
message = Exception.message(exception)
assert message =~ "Actor: %{id: \"#{actor_id}\"}"
assert message =~ "authorize if: is old enough to drink | age > 21 | ? | 🔎"
assert message =~ "authorize if: id == \"#{actor_id}\" | ? | 🔎"
end
test "strict read policies do not result in a filter" do
thing =
ResourceWithAStrictReadPolicy
|> Ash.create!(authorize?: false)
actor = %{id: thing, admin: false}
assert_raise Ash.Error.Forbidden, fn ->
ResourceWithAStrictReadPolicy
|> Ash.Query.new()
|> Ash.DataLayer.Simple.set_data([thing])
|> Ash.read!(actor: actor)
end
assert [] =
ResourceWithAStrictReadPolicy
|> Ash.Query.new()
|> Ash.DataLayer.Simple.set_data([%{thing | id: Ash.UUID.generate()}])
|> Ash.read!(actor: %{admin: true})
end
test "bypass with condition does not apply subsequent filters", %{admin: admin, user: user} do
Ash.create!(Ash.Changeset.for_create(Tweet, :create), authorize?: false)
assert [_] = Ash.read!(Tweet, actor: admin)
assert [] = Ash.read!(Tweet, actor: user)
end
test "Ash.can? accepts a record to determine if it can be read", %{admin: admin, user: user} do
tweet = Ash.create!(Ash.Changeset.for_create(Tweet, :create), authorize?: false)
assert Ash.can?({tweet, :read}, admin)
refute Ash.can?({tweet, :read}, user)
end
test "arguments can be referenced in expression policies", %{admin: admin, user: user} do
Tweet
|> Ash.Changeset.for_create(:create_foo, %{foo: "foo", user_id: admin.id}, actor: user)
|> Ash.create!()
assert_raise Ash.Error.Forbidden, fn ->
Tweet
|> Ash.Changeset.for_create(:create_foo, %{foo: "bar", user_id: admin.id}, actor: user)
|> Ash.create!()
end
end
test "functions can be used as checks through `matches`", %{user: user} do
Tweet
|> Ash.Changeset.for_create(:create_bar, %{bar: 2}, actor: user)
|> Ash.create!()
Tweet
|> Ash.Changeset.for_create(:create_bar, %{bar: 9}, actor: user)
|> Ash.create!()
assert_raise Ash.Error.Forbidden, fn ->
Tweet
|> Ash.Changeset.for_create(:create_bar, %{bar: 1}, actor: user)
|> Ash.create!()
end
end
test "filter checks work on create/update/destroy actions", %{user: user} do
user2 = Ash.create!(Ash.Changeset.for_create(User, :create), authorize?: false)
assert_raise Ash.Error.Forbidden, fn ->
Ash.update!(Ash.Changeset.for_update(user, :update), actor: user2)
end
end
test "relating_to_actor/1 works when creating", %{user: user} do
Tweet
|> Ash.Changeset.for_create(:create, %{user_id: user.id})
|> Ash.create!(authorize?: true, actor: user)
assert_raise Ash.Error.Forbidden, fn ->
Tweet
|> Ash.Changeset.for_create(:create, %{user_id: Ash.UUID.generate()})
|> Ash.create!(authorize?: true, actor: user)
end
end
test "relating_to_actor/1 works when updating", %{user: user} do
Tweet
|> Ash.Changeset.for_create(:create, %{user_id: user.id})
|> Ash.create!(authorize?: false, actor: user)
Ash.bulk_update!(Tweet, :set_user, %{user_id: user.id},
actor: user,
authorize?: true,
authorize_with: :error
)
assert_raise Ash.Error.Forbidden, fn ->
Ash.bulk_update!(Tweet, :set_user, %{user_id: Ash.UUID.generate()},
actor: user,
authorize?: true,
authorize_with: :error
)
end
end
test "relating_to_actor/1 works when updating non-atomically", %{user: user} do
tweet =
Tweet
|> Ash.Changeset.for_create(:create, %{user_id: user.id})
|> Ash.create!(authorize?: false, actor: user)
tweet
|> Ash.Changeset.for_update(:set_user, %{user_id: user.id}, actor: user, authorize?: true)
|> Ash.update!()
assert_raise Ash.Error.Forbidden, fn ->
tweet
|> Ash.Changeset.for_update(:set_user, %{user_id: Ash.UUID.generate()},
actor: user,
authorize?: true
)
|> Ash.update!()
end
end
test "filter checks work on update/destroy actions", %{user: user} do
tweet =
Tweet
|> Ash.Changeset.for_create(:create)
|> Ash.Changeset.manage_relationship(:user, user, type: :append_and_remove)
|> Ash.create!(authorize?: false)
changeset = Ash.Changeset.for_update(tweet, :update)
assert Ash.Policy.Info.strict_check(user, changeset, Domain) == true
tweet =
Tweet
|> Ash.Changeset.for_create(:create)
|> Ash.create!(authorize?: false)
changeset = Ash.Changeset.for_update(tweet, :update)
assert Ash.Policy.Info.strict_check(%{user | id: nil}, changeset, Domain) == false
end
test "non-filter checks work on create/update/destroy actions" do
user = Ash.create!(Ash.Changeset.for_create(User, :create), authorize?: false)
assert_raise Ash.Error.Forbidden, fn ->
Ash.create!(Ash.Changeset.for_create(Post, :create, %{text: "foo"}), actor: user)
end
end
test "filter checks work with related data", %{user: user} do
organization =
Organization
|> Ash.Changeset.for_create(:create, %{owner: user.id})
|> Ash.create!(authorize?: false)
post1 =
Post
|> Ash.Changeset.for_create(:create, %{author: user.id, text: "aaa"})
|> Ash.create!(authorize?: false)
post2 =
Post
|> Ash.Changeset.for_create(:create, %{organization: organization.id, text: "bbb"})
|> Ash.create!(authorize?: false)
Post
|> Ash.Changeset.for_create(:create, %{text: "invalid"})
|> Ash.create!(authorize?: false)
ids =
Post
|> Ash.read!(actor: user)
|> Enum.map(& &1.id)
|> Enum.sort()
assert ids == Enum.sort([post1.id, post2.id])
end
test "authorize_with `:error` is an error if any records don't match", %{user: user} do
post1 =
Post
|> Ash.Changeset.for_create(:create, %{author: user.id, text: "aaa"})
|> Ash.create!(authorize?: false)
Post
|> Ash.Changeset.for_create(:create, %{text: "invalid"})
|> Ash.create!(authorize?: false)
ids =
Post
|> Ash.read!(actor: user)
|> Enum.map(& &1.id)
|> Enum.sort()
assert ids == Enum.sort([post1.id])
assert_raise Ash.Error.Forbidden, fn ->
Post
|> Ash.read!(actor: user, authorize_with: :error)
end
end
test "filter policies bypassed for calculations", %{user: user} do
other_user = Ash.create!(Ash.Changeset.for_create(User, :create), authorize?: false)
Post
|> Ash.Changeset.for_create(:create, %{author: user.id, text: "aaa"})
|> Ash.create!(authorize?: false)
assert %{post_texts: ["aaa"]} =
Ash.load!(user, :post_texts, actor: other_user)
end
test "authorize_unless properly combines", %{user: user} do
Car
|> Ash.Changeset.for_create(:authorize_unless, %{})
|> Ash.create!(actor: user)
end
test "filter checks work on generic actions when they don't reference anything specifically", %{
admin: admin,
user: user
} do
assert_raise Ash.Error.Forbidden, fn ->
Post
|> Ash.ActionInput.for_action(:say_hello, %{from_an_admin?: true, to: "Fred"}, actor: user)
|> Ash.run_action!()
end
assert "Hello Fred from an admin!" ==
Post
|> Ash.ActionInput.for_action(:say_hello, %{from_an_admin?: true, to: "Fred"},
actor: admin
)
|> Ash.run_action!()
end
test "filter checks work with many to many related data and a filter", %{user: user} do
car1 =
Car
|> Ash.Changeset.for_create(:create, %{users: [user.id]})
|> Ash.create!(authorize?: false)
car2 =
Car
|> Ash.Changeset.for_create(:create, %{})
|> Ash.create!(authorize?: false)
results =
Car
|> Ash.Query.filter(id == ^car2.id)
|> Ash.read!(actor: user)
assert results == []
results =
Car
|> Ash.Query.filter(id == ^car1.id)
|> Ash.read!(actor: user)
|> Enum.map(& &1.id)
assert results == [car1.id]
end
test "calculations that reference aggregates are properly authorized", %{user: user} do
Car
|> Ash.Changeset.for_create(:create, %{users: [user.id], active: false}, authorize?: false)
|> Ash.create!()
assert %{restricted_from_driving: false, has_car: true} =
user
|> Ash.load!([:restricted_from_driving, :has_car], authorize?: false)
|> Map.take([:restricted_from_driving, :has_car])
assert %{restricted_from_driving: true, has_car: false} =
user
|> Ash.load!([:restricted_from_driving, :has_car], authorize?: true)
|> Map.take([:restricted_from_driving, :has_car])
end
test "filter checks work via deeply related data", %{user: user} do
assert Ash.read!(Trip, actor: user) == []
end
test "changing_attributes with `:to` option works" do
Foo
|> Ash.Changeset.for_create(:create, %{name: "Foo"})
|> Ash.create!()
end
test "checking context using expr works" do
%{id: id} =
context =
Context
|> Ash.Changeset.for_create(:create, %{name: "Foo"})
|> Ash.create!()
assert [%{id: ^id}] = Ash.read!(Context, context: %{name: "Foo"}, authorize?: true)
assert %{name: "Bar"} =
context
|> Ash.Changeset.for_update(:update, %{name: "Bar"},
context: %{name: "Foo"},
authorize?: true
)
|> Ash.update!()
assert %{name: "Foo"} =
Domain.update_context!(id, "Foo",
context: %{name: "Bar"},
actor: nil,
authorize?: true
)
end
test "a final always policy with a forbid if always is properly applied" do
user = Ash.create!(Ash.Changeset.for_create(User, :create), authorize?: false)
Ash.Test.Support.PolicySimple.Always
|> Ash.Changeset.for_create(:create, %{user_id: user.id})
|> Ash.create!(authorize?: false)
assert_raise Ash.Error.Forbidden, fn ->
Ash.Test.Support.PolicySimple.Always
|> Ash.read!(authorize?: true, actor: user)
end
end
test "two filter condition checks combine properly" do
user1 = Ash.create!(Ash.Changeset.for_create(User, :create), authorize?: false)
user2 = Ash.create!(Ash.Changeset.for_create(User, :create), authorize?: false)
user1_thing =
Ash.Test.Support.PolicySimple.TwoFilters
|> Ash.Changeset.for_create(:create, %{user_id: user1.id})
|> Ash.create!(authorize?: false)
user2_thing =
Ash.Test.Support.PolicySimple.TwoFilters
|> Ash.Changeset.for_create(:create, %{user_id: user2.id})
|> Ash.create!(authorize?: false)
assert [user1_got_thing] =
Ash.Test.Support.PolicySimple.TwoFilters
|> Ash.read!(authorize?: true, actor: user1)
assert user1_got_thing.id == user1_thing.id
assert [user2_got_thing] =
Ash.Test.Support.PolicySimple.TwoFilters
|> Ash.read!(authorize?: true, actor: user2)
assert user2_got_thing.id == user2_thing.id
end
end