mirror of
https://github.com/team-alembic/ash_authentication.git
synced 2024-09-19 12:52:55 +12:00
improvement: avoid warning about comparison with nil
the previous implementation was not a security issue because the actual action would not execute with a `nil` identity
This commit is contained in:
parent
c4f570380f
commit
d9a278395a
2 changed files with 10 additions and 4 deletions
|
@ -26,8 +26,11 @@ defmodule AshAuthentication.Strategy.MagicLink.RequestPreparation do
|
|||
identity = Query.get_argument(query, identity_field)
|
||||
select_for_senders = Info.authentication_select_for_senders!(query.resource)
|
||||
|
||||
query
|
||||
|> Query.filter(^ref(identity_field) == ^identity)
|
||||
if is_nil(identity) do
|
||||
Query.filter(query, false)
|
||||
else
|
||||
Query.filter(query, ^ref(identity_field) == ^identity)
|
||||
end
|
||||
|> Query.before_action(fn query ->
|
||||
Ash.Query.ensure_selected(query, select_for_senders)
|
||||
end)
|
||||
|
|
|
@ -27,8 +27,11 @@ defmodule AshAuthentication.Strategy.Password.RequestPasswordResetPreparation do
|
|||
identity = Query.get_argument(query, identity_field)
|
||||
select_for_senders = Info.authentication_select_for_senders!(query.resource)
|
||||
|
||||
query
|
||||
|> Query.filter(^ref(identity_field) == ^identity)
|
||||
if is_nil(identity) do
|
||||
Query.filter(query, false)
|
||||
else
|
||||
Query.filter(query, ^ref(identity_field) == ^identity)
|
||||
end
|
||||
|> Query.before_action(fn query ->
|
||||
Ash.Query.ensure_selected(query, select_for_senders)
|
||||
end)
|
||||
|
|
Loading…
Reference in a new issue