chore: fix page title crashes

This commit is contained in:
Zach Daniel 2023-01-17 23:53:21 -05:00
parent de8eb3a50b
commit 3c6b5bbe4e
3 changed files with 9 additions and 7 deletions

View file

@ -772,7 +772,7 @@ defmodule AshHqWeb.Pages.Docs do
) )
socket.assigns.mix_task -> socket.assigns.mix_task ->
send(self(), {:page_title, socket.assigns.module.name}) send(self(), {:page_title, socket.assigns.mix_task.name})
assign(socket, assign(socket,
docs: socket.assigns.mix_task.html_for, docs: socket.assigns.mix_task.html_for,
@ -783,7 +783,7 @@ defmodule AshHqWeb.Pages.Docs do
) )
socket.assigns.dsl -> socket.assigns.dsl ->
send(self(), {:page_title, socket.assigns.module.name}) send(self(), {:page_title, socket.assigns.dsl.name})
meta_name = meta_name =
Enum.join( Enum.join(
@ -813,6 +813,8 @@ defmodule AshHqWeb.Pages.Docs do
) )
socket.assigns.extension -> socket.assigns.extension ->
send(self(), {:page_title, socket.assigns.extension.name})
assign(socket, assign(socket,
docs: socket.assigns.extension.html_for, docs: socket.assigns.extension.html_for,
title: "Extension: #{socket.assigns.extension.name}", title: "Extension: #{socket.assigns.extension.name}",
@ -822,6 +824,8 @@ defmodule AshHqWeb.Pages.Docs do
) )
socket.assigns.guide -> socket.assigns.guide ->
send(self(), {:page_title, socket.assigns.guide.name})
assign(socket, assign(socket,
title: "Guide: #{socket.assigns.guide.name}", title: "Guide: #{socket.assigns.guide.name}",
docs: socket.assigns.guide.html_for, docs: socket.assigns.guide.html_for,

View file

@ -187,7 +187,7 @@ defmodule AshHqWeb.AppViewLive do
end end
def handle_info({:page_title, title}, socket) do def handle_info({:page_title, title}, socket) do
assign(socket, :page_title, "Ash Framework - #{title}") {:noreply, assign(socket, :page_title, "Ash Framework - #{title}")}
end end
def handle_event("remove_version", %{"library" => library}, socket) do def handle_event("remove_version", %{"library" => library}, socket) do

View file

@ -590,8 +590,7 @@ acc = %{
extensions: [], extensions: [],
guides: Utils.guides(mix_project, String.to_atom(name)), guides: Utils.guides(mix_project, String.to_atom(name)),
modules: [], modules: [],
mix_tasks: [], mix_tasks: []
default_guide: mix_project.project[:docs][:spark][:default_guide]
} }
extensions = mix_project.project[:docs][:spark][:extensions] || mix_project.project[:docs][:spark_extensions] extensions = mix_project.project[:docs][:spark][:extensions] || mix_project.project[:docs][:spark_extensions]
@ -605,7 +604,7 @@ all_modules =
all_modules all_modules
|> Kernel.||([]) |> Kernel.||([])
|> Enum.reject(fn module -> |> Enum.reject(fn module ->
Enum.find(extensions || [], &(&1.target == inspect(module))) Enum.find(extensions || [], &(&1.module == module))
end) end)
all_modules = all_modules =
@ -621,7 +620,6 @@ all_modules =
acc = acc =
mix_project.project[:docs][:groups_for_modules] mix_project.project[:docs][:groups_for_modules]
|> Kernel.||([{"Miscellaneous", ~r/.*/}])
|> Enum.reduce(acc, fn {category, modules}, acc -> |> Enum.reduce(acc, fn {category, modules}, acc ->
modules = modules =
Utils.modules_for(all_modules, modules) Utils.modules_for(all_modules, modules)