improvement: don't log on raised exception, for consistency

we don't raise when an error is returned, so we won't raise when an error
is raised. It will eventually cause a job failure in Oban.
This commit is contained in:
Zach Daniel 2023-12-04 17:56:50 -05:00
parent 09fa2c28f4
commit d857705f8c

View file

@ -543,15 +543,12 @@ defmodule AshOban.Transformers.DefineSchedulers do
end
rescue
error ->
error = Ash.Error.to_ash_error(error, __STACKTRACE__)
Logger.error("""
Error handler failed for #{inspect(unquote(resource))}: #{inspect(primary_key)}!
#{inspect(Exception.format(:error, error, AshOban.stacktrace(error)))}
""")
handle_error(job, error, primary_key, __STACKTRACE__)
handle_error(
job,
Ash.Error.to_ash_error(error, __STACKTRACE__),
primary_key,
__STACKTRACE__
)
end
end
end