ash-project/ash_phoenix
1
0
Fork 0
mirror of https://github.com/ash-project/ash_phoenix.git synced 2024-09-19 23:02:48 +12:00
Code Issues Projects Releases Packages Wiki Activity

fix: make sure that _index is correctly updated before and after removal for sparse forms (#196) (#197)

Browse source
This commit is contained in:
danielatdpg 2024-05-29 16:54:13 +02:00 committed by GitHub
parent 76b61ba024
commit e199d465b7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 51 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ash_phoenix/form/form.ex
View file

@ -3315,6 +3315,7 @@ defmodule AshPhoenix.Form do
nested_form
| name: new_name,
id: new_id,
params: add_index(nested_form.params, i, form.opts[:forms][key]),
forms:
replace_form_names(
nested_form.forms,
@ -4025,7 +4026,7 @@ defmodule AshPhoenix.Form do
matching_form =
if sparse? do
Enum.find(forms, fn form ->
form.params["_index"] == key
form.params["_index"] == to_string(key)
end)
else
Enum.at(forms, index)
@ -4224,6 +4225,7 @@ defmodule AshPhoenix.Form do
actor: actor,
tenant: tenant,
errors: error?,
params: add_index(params, index, opts),
accessing_from: opts[:managed_relationship],
prepare_source: opts[:prepare_source],
warn_on_unhandled_errors?: warn_on_unhandled_errors?,

48
test/form_test.exs
View file

@ -1583,6 +1583,54 @@ defmodule AshPhoenix.FormTest do
assert form_1.id == "form_posts_1"
end
test "sparse forms can also be removed by index" do
post1_id = Ash.UUID.generate()
post2_id = Ash.UUID.generate()
post3_id = Ash.UUID.generate()
comment = %Comment{
text: "text",
post: [%Post{id: post1_id}, %Post{id: post2_id}, %Post{id: post3_id}]
}
form =
comment
|> Form.for_update(:update,
forms: [
posts: [
data: comment.post,
type: :list,
resource: Post,
create_action: :create,
update_action: :update,
sparse?: true
]
]
)
|> Form.remove_form([:posts, 1])
assert [
%Phoenix.HTML.Form{source: %AshPhoenix.Form{resource: AshPhoenix.Test.Post}} =
form_0,
%Phoenix.HTML.Form{source: %AshPhoenix.Form{resource: AshPhoenix.Test.Post}} =
form_1
] = inputs_for(form_for(form, "action"), :posts)
assert form_0.name == "form[posts][0]"
assert form_0.id == "form_posts_0"
assert form_1.name == "form[posts][1]"
assert form_1.id == "form_posts_1"
form =
form
|> Form.remove_form([:posts, 1])
assert [
%Phoenix.HTML.Form{source: %AshPhoenix.Form{resource: AshPhoenix.Test.Post}}
] = inputs_for(form_for(form, "action"), :posts)
end
test "when `:single`, `inputs_for` generates a list of one single item" do
post_id = Ash.UUID.generate()
comment = %Comment{text: "text", post: %Post{id: post_id, text: "Some text"}}