From 27b6808408d7cf80cc7b02d53880f6239af0b5cb Mon Sep 17 00:00:00 2001 From: Zach Daniel Date: Mon, 8 Jul 2024 15:58:24 -0400 Subject: [PATCH] fix: remove erroneous warning while composing tasks --- lib/igniter/util/info.ex | 6 ++++-- lib/mix/task.ex | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/igniter/util/info.ex b/lib/igniter/util/info.ex index 900dd35..c5c3fbb 100644 --- a/lib/igniter/util/info.ex +++ b/lib/igniter/util/info.ex @@ -93,14 +93,16 @@ defmodule Igniter.Util.Info do parent, composing_task_name ), - composes: List.wrap(composing_schema.composes) ++ rest, + composes: rest, extra_args?: schema.extra_args? || composing_schema.extra_args?, installs: Keyword.merge(composing_schema.installs, schema.installs), adds_deps: Keyword.merge(composing_schema.adds_deps, schema.adds_deps) }, argv, - composing_task_name + parent ) + |> Map.put(:composes, List.wrap(composing_schema.composes)) + |> recursively_compose_schema(argv, composing_task_name) else _ -> recursively_compose_schema( diff --git a/lib/mix/task.ex b/lib/mix/task.ex index 50b8abc..5cec647 100644 --- a/lib/mix/task.ex +++ b/lib/mix/task.ex @@ -115,6 +115,8 @@ defmodule Igniter.Mix.Task do require Logger if source && source != "igniter.install" do + raise "what" + Logger.warning(""" The task #{Mix.Task.task_name(__MODULE__)} is being composed by #{source}, but it does not declare an option schema. Therefore, all options will be allowed. Tasks that may be composed should define `info/2`.