From 79ae2d653bbf014e18913403f13fb0f8ff0b12a1 Mon Sep 17 00:00:00 2001 From: Zach Daniel Date: Sun, 4 Aug 2024 22:43:27 -0400 Subject: [PATCH] Revert "fix: escape injected code in Common.replace_code/2 (#70)" (#72) This reverts commit bba8d5238e7309b865cbcfa34c0b8273e427649d. --- lib/igniter/code/common.ex | 2 +- test/igniter/project/config_test.exs | 22 ---------------------- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/lib/igniter/code/common.ex b/lib/igniter/code/common.ex index e68602b..03b8f72 100644 --- a/lib/igniter/code/common.ex +++ b/lib/igniter/code/common.ex @@ -272,7 +272,7 @@ defmodule Igniter.Code.Common do def replace_code(zipper, code) do # code = use_aliases(code, zipper) - Zipper.replace(zipper, code |> Macro.to_string() |> Sourceror.parse_string!()) + Zipper.replace(zipper, code) end def extendable_block?({:__block__, meta, contents}) when is_list(contents) do diff --git a/test/igniter/project/config_test.exs b/test/igniter/project/config_test.exs index 2fad730..526cb5e 100644 --- a/test/igniter/project/config_test.exs +++ b/test/igniter/project/config_test.exs @@ -234,28 +234,6 @@ defmodule Igniter.Project.ConfigTest do """ end - @tag :regression - test "arbitrary data structures can be used as values" do - %{rewrite: rewrite} = - Igniter.new() - |> Igniter.create_new_elixir_file("config/fake.exs", """ - import Config - - config :level1, :level2, level3: [{"hello", "world"}] - """) - |> Igniter.Project.Config.configure("fake.exs", :level1, [:level2, :level3], [ - {"hello1", "world1"} - ]) - - config_file = Rewrite.source!(rewrite, "config/fake.exs") - - assert Source.get(config_file, :content) == """ - import Config - - config :level1, :level2, level3: [{"hello1", "world1"}] - """ - end - test "present values can be updated by updating map keys" do %{rewrite: rewrite} = Igniter.new()