james/lex_luthor
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix for expensive string length check while consuming input. #4

Merged
jimsynz merged 2 commits from fix-big-o into master 2021-01-28 08:49:50 +13:00
Conversation 6 Commits 2 Files changed 8 +172 -153
jimsynz commented 2021-01-27 10:23:27 +13:00 (Migrated from github.com)
Copy link

Thanks to @nbryant42 for bringing this to my attention.

Thanks to @nbryant42 for bringing this to my attention.
jimsynz commented 2021-01-27 10:24:07 +13:00 (Migrated from github.com)
Copy link

@nbryant42 can you check that this branch fixes #3?

@nbryant42 can you check that this branch fixes #3?
nbryant42 commented 2021-01-27 13:53:28 +13:00 (Migrated from github.com)
Copy link

Thanks for the quick fix. I'll test it tomorrow.

Thanks for the quick fix. I'll test it tomorrow.
nbryant42 commented 2021-01-28 07:04:42 +13:00 (Migrated from github.com)
Copy link

I can confirm that this is major performance improvement; a task that previously took minutes before I gave up waiting now completes in 3 seconds. Also, it still passes my syntax unit tests.

I can confirm that this is major performance improvement; a task that previously took minutes before I gave up waiting now completes in 3 seconds. Also, it still passes my syntax unit tests.
nbryant42 commented 2021-01-28 07:15:37 +13:00 (Migrated from github.com)
Copy link

Scaling looks pretty linear now. I'm not going to try to confirm that definitively, because of the way my test script is setup, but... it's pretty close, I think.

Scaling looks pretty linear now. I'm not going to try to confirm that definitively, because of the way my test script is setup, but... it's pretty close, I think.
jimsynz commented 2021-01-28 08:41:30 +13:00 (Migrated from github.com)
Copy link

@nbryant42 I'm sure that there are plenty of other places we can make it go faster. If you find something definitely let me know. I'm going to merge this now.

@nbryant42 I'm sure that there are plenty of other places we can make it go faster. If you find something definitely let me know. I'm going to merge this now.
jimsynz commented 2021-01-28 08:59:12 +13:00 (Migrated from github.com)
Copy link

Version 0.1.2 has been released to hex. https://hex.pm/packages/lex_luthor/0.1.2

Version 0.1.2 has been released to hex. https://hex.pm/packages/lex_luthor/0.1.2
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: james/lex_luthor#4
No description provided.
Delete branch "fix-big-o"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?