ash-project/igniter
1
0
Fork 0
mirror of https://github.com/ash-project/igniter.git synced 2024-09-20 05:22:52 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: remove erroneous warning while composing tasks
Some checks are pending
CI / ash-ci (push) Waiting to run
Details

Browse source
This commit is contained in:
Zach Daniel 2024-07-08 15:58:24 -04:00
parent a7e1397940
commit 27b6808408
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/igniter/util/info.ex
View file

@ -93,14 +93,16 @@ defmodule Igniter.Util.Info do
parent, parent,
composing_task_name composing_task_name
), ),
composes: List.wrap(composing_schema.composes) ++ rest, composes: rest,
extra_args?: schema.extra_args? || composing_schema.extra_args?, extra_args?: schema.extra_args? || composing_schema.extra_args?,
installs: Keyword.merge(composing_schema.installs, schema.installs), installs: Keyword.merge(composing_schema.installs, schema.installs),
adds_deps: Keyword.merge(composing_schema.adds_deps, schema.adds_deps) adds_deps: Keyword.merge(composing_schema.adds_deps, schema.adds_deps)
}, },
argv, argv,
composing_task_name parent
) )
|> Map.put(:composes, List.wrap(composing_schema.composes))
|> recursively_compose_schema(argv, composing_task_name)
else else
_ -> _ ->
recursively_compose_schema( recursively_compose_schema(

2
lib/mix/task.ex
View file

@ -115,6 +115,8 @@ defmodule Igniter.Mix.Task do
require Logger require Logger
if source && source != "igniter.install" do if source && source != "igniter.install" do
raise "what"
Logger.warning(""" Logger.warning("""
The task #{Mix.Task.task_name(__MODULE__)} is being composed by #{source}, but it does not declare an option schema. The task #{Mix.Task.task_name(__MODULE__)} is being composed by #{source}, but it does not declare an option schema.
Therefore, all options will be allowed. Tasks that may be composed should define `info/2`. Therefore, all options will be allowed. Tasks that may be composed should define `info/2`.