james/wafer
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

Allow circuits_i2c version 1.x #36

Merged
balexand1 merged 8 commits from i2c_1x into main 2023-08-21 15:33:04 +12:00
Conversation 3 Commits 8 Files changed 2 +28 -1
balexand1 commented 2023-08-19 11:33:40 +12:00 (Migrated from gitlab.com)
Copy link

Thanks for creating this library and also for creating ina219. I came across this today while trying to get started using an INA260.

In 411c0c4367 mix.exs was updated to force an update to circuits_i2c version 2.0. It doesn't seem like this is necessary. Forcing an update makes things difficult for app developers because some of their I2C dependencies might still depend upon circuits_i2c 1.0. Supporting both 1.0 and 2.0 allows developers time to upgrade.

I added CI to test with circuits_i2c 1.0. I've never used Gitlab before so I'm not sure if this is the best way to do this. Let me know if you'd prefer that I remove the CI changes.

If you do decide to force an update to 2.0 then I suggest bumping the version of this library to 2.0 since it is a breaking change (see https://semver.org/). Also, it would allow the possibility of more releases in the 1.0 branch.

Thanks.

Thanks for creating this library and also for creating `ina219`. I came across this today while trying to get started using an INA260. In https://gitlab.com/jimsy/wafer/-/commit/411c0c4367ccfbe7c1e202dac2a854bbe7805d52 `mix.exs` was updated to force an update to `circuits_i2c` version 2.0. It doesn't seem like this is necessary. Forcing an update makes things difficult for app developers because some of their I2C dependencies might still depend upon `circuits_i2c` 1.0. Supporting both 1.0 and 2.0 allows developers time to upgrade. I added CI to test with `circuits_i2c` 1.0. I've never used Gitlab before so I'm not sure if this is the best way to do this. Let me know if you'd prefer that I remove the CI changes. If you do decide to force an update to 2.0 then I suggest bumping the version of this library to 2.0 since it is a breaking change (see https://semver.org/). Also, it would allow the possibility of more releases in the 1.0 branch. Thanks.
jimsy (Migrated from gitlab.com) approved these changes 2023-08-19 11:33:40 +12:00
balexand1 commented 2023-08-19 11:34:31 +12:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
jimsy commented 2023-08-21 15:23:53 +12:00 (Migrated from gitlab.com)
Copy link

Thanks for the contribution!

Thanks for the contribution!
jimsy commented 2023-08-21 15:24:03 +12:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
Sign in to join this conversation.
Reviewers
No reviewers
jimsy
Labels
Clear labels   
renovate
No labels
renovate
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: james/wafer#36
No description provided.
Delete branch "i2c_1x"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?